docs(local-models): add vllm hidden-state serving notes#13
Conversation
|
00164a6 to
bab0ebe
Compare
|
@sir-merge-a-lot groom |
|
🤖 sir-merge-a-lot Rebase succeededRebased Why now: this PR needed to be rebased onto 📖 How rebases run · Force-with-lease and backup refs🤖 sir-merge-a-lot · why this happened? · pause / opt out · Updated 2026-07-09 18:41:04 UTC |
ab7ed14 to
1977ff4
Compare
WalkthroughThis PR adds a new documentation page, ChangesHidden-State Serving Docs
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/vllm-serve-hidden-state.md`:
- Around line 81-97: The smoke test still selects the newest .safetensors file
instead of using the hidden-state path returned by vLLM. Update the Python
snippet in the hidden-state docs to read and open the actual path from
kv_transfer_params.hidden_states_path, and use that value consistently when
printing tensor metadata so the test validates the correct run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 91b5ffaf-496b-478c-92bd-16fd32ed21cd
📒 Files selected for processing (2)
docs/vllm-serve-hidden-state.mdmkdocs.yml
Signed-off-by: Sabhatina Selvam <sabhatinas@nvidia.com>
Signed-off-by: Sabhatina Selvam <sabhatinas@nvidia.com>
8af1fba to
85f4918
Compare
Summary
vllm servecommand.Validation
uv run --only-group docs mkdocs build --strictSummary by CodeRabbit