-
Notifications
You must be signed in to change notification settings - Fork 539
[NVBug: 6563509] Drop Phi-3-vision / Phi-4-multimodal PTQ support #2115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cjluo-nv
wants to merge
10
commits into
main
Choose a base branch
from
chenjiel/nvbug-6563509-meta-init-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
90c984e
[NVBug: 6563509] Don't abort model load when the meta-device skeleton…
cjluo-nv d94911b
[NVBug: 6563509] Drop Phi-3-vision / Phi-4-multimodal PTQ support
cjluo-nv 876dd8c
Move NVBug 6563509 changelog entries into 0.46
cjluo-nv 8444c11
Address PR review: extract skeleton helper, fix OOM hint, drop README…
cjluo-nv 1b062da
Simplify sizing skeleton to a single include_buffers=False build
cjluo-nv 17dfd3b
Clarify in the changelog why Phi-3-vision is dropped
cjluo-nv 4e0157d
Size the device map from the checkpoint instead of a constructed model
cjluo-nv 1b6a79d
Stop auto-capping GPU memory for device_map="auto"
cjluo-nv 701180e
Revert all device-map sizing changes; keep only the Phi deprecation
cjluo-nv c67c8b0
Drop the stale phi4mm reference from the 0.46 DiffusionGemma entry
cjluo-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
modelopt_recipes/huggingface/phi4mm/ptq/disabled_quantizers.yaml
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
modelopt_recipes/huggingface/phi4mm/ptq/nvfp4-kv_fp8_cast.yaml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still says Phi-3-vision “no longer loads on any version ModelOpt supports,” but the author’s reply confirms it was not tested on supported Transformers 4.57 and that its identified
_tied_weights_keysblocker is a 5.x failure. If the removal is a product decision because the model is superseded, document that rationale instead of making an unverified compatibility claim (or provide the 4.57 repro/blocker).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 17dfd3b — you were right that the entry was making an unverified claim.
The changelog now splits the two rationales. Phi-4-multimodal is described as unloadable on any supported version, which the matrix does support. Phi-3-vision is described as a supersession removal: "dropped alongside it: it is the older, superseded model in the same family, so with its successor unsupportable there is no reason to keep carrying the predecessor." A parenthetical records what was actually verified — it shares the list-valued
_tied_weights_keysdefect so is broken on Transformers 5.x, but does not hit thepeftblocker. No 4.57 claim is made for it. The PR description carries the same split.