[None][perf] Add CUTEDSL FC2 N-tile tuning override - #17015
Draft
peihu-nv wants to merge 1 commit into
Draft
Conversation
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #62584 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #62584 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Small per-expert FC2 GEMMs in WideEP can favor a different N tile size than larger MoE shapes. The existing CuTeDSL autotuner evaluates N128 and N256 tactics, but it has no way to pin one candidate for controlled tuning and deployment.
Add a strict
TRTLLM_CUTEDSL_FC2_N_TILE_SIZEoverride to the FC2 finalize-fusion runner. Values128and256select the corresponding candidate; leaving the variable unset preserves the existing autotuned behavior. The selected value is included in the runner identity so tuning caches cannot collide, and unsupported values fail fast.For DeepSeek-R1 FP4 WideEP EP32 decode on B200, selecting N128 improved the position-balanced MBS32 point by 1.82% and the full-Pareto geometric mean by 1.22%.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.