[None][feat] Add vendored openengine protos and generated gRPC stubs - #17019
Closed
tanmayv25 wants to merge 1 commit into
Closed
[None][feat] Add vendored openengine protos and generated gRPC stubs#17019tanmayv25 wants to merge 1 commit into
tanmayv25 wants to merge 1 commit into
Conversation
tanmayv25
force-pushed
the
user/tanmayv25/openengine-grpc-support
branch
2 times, most recently
from
July 29, 2026 23:33
71f206f to
b4bef7c
Compare
First step toward openengine gRPC protocol support (see RFC NVIDIA#17016). Vendors the openengine v1 .proto contract from ai-dynamo/openengine at a pinned commit and commits the generated Python/gRPC stubs. No external pip package is added; the stubs need only the grpcio/protobuf runtimes already used for gRPC serving. - Vendored protos under proto/openengine/v1/ (pinned commit recorded in PIN.md) - Committed *_pb2 / *_pb2_grpc / *.pyi stubs (grpcio-tools 1.64.1, gencode 5.26) - generate_stubs.sh regenerates the stubs from the vendored protos - Exclude the vendored protos and generated stubs from formatters/linters Servicer, converters, and serve.py wiring follow in later changes. Signed-off-by: tanmayv25 <tanmay2592@gmail.com>
tanmayv25
force-pushed
the
user/tanmayv25/openengine-grpc-support
branch
from
July 30, 2026 17:39
b4bef7c to
5e70244
Compare
Collaborator
Author
|
Instead of copying proto, will go via buf route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First implementation step for openengine gRPC protocol support in
trtllm-serve. Part of RFC #17016.This vendors the openengine v1
.protocontract and commits the generated Python/gRPC stubs. It adds no new external pip dependency — the stubs need only thegrpcio/protobufruntimes, which are already pulled in transitively viasmg-grpc-proto.What's included
tensorrt_llm/grpc/openengine/proto/openengine/v1/, pinned to openengine commitb8d052f(recorded inPIN.md).*_pb2.py,*_pb2_grpc.py,*.pyi), flat in the package, with cross-imports rewritten to package-relative.generate_stubs.shto regenerate the stubs from the vendored protos (grpcio-tools==1.64.1; gencode targets Protobuf Python 5.26.1)..pre-commit-config.yaml: exclude the vendored protos and generated stubs from formatters/linters — the stubs stay byte-identical togenerate_stubs.shoutput, and the vendored.proto/LICENSE are left untouched.Design (per RFC #17016)
--grpc-protocol.buf— self-contained, hermetic, no build-time codegen.Not in this PR (follow-ups)
OpenEngineInferenceServicer+OpenEngineControlServicer.SamplingParams/ stopping / response / guided-decoding converters.--grpc-protocol {smg,openengine}wiring inserve.py.api_stabilityreference update.Test