-
Notifications
You must be signed in to change notification settings - Fork 741
[JAX] [PyT] [Common] Enable D=256 BWD cuDNN fused attn for Blackwell CC 10.x #3056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KshitijLakhani
wants to merge
15
commits into
NVIDIA:main
Choose a base branch
from
KshitijLakhani:klakhani/feat/enable-headdim256-bwd-sm100
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
84a8e11
Refine the support for D=256 on Blackwell server type GPUs
KshitijLakhani 0d30f41
Add deterministic tests for D=256 for sm10.x
KshitijLakhani c214b36
Test clean up
KshitijLakhani 24a7d2c
Add PyT side tests for D=256 cuDNN fused attn on SM100-110
KshitijLakhani 195b72c
Refine the PyT D=256 tests
KshitijLakhani 1b03f3e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 580af29
Fix the filtering condition for bias type for D=256 on sm10x for cudn…
KshitijLakhani 4474eda
Code clean up
KshitijLakhani e57ca7d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 927fab4
Switching test check logic around
KshitijLakhani e08e9e8
Add THD xfail marked tests for testing
KshitijLakhani b8fe919
Fix the jax test bias condition fo skipping for D=256
KshitijLakhani 379242b
nit: Fix comment
KshitijLakhani a264de1
Move the D=256 changes so as to follow an order of increasing cuDNN v…
KshitijLakhani 5063b39
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these checks duplicate to the checks we added on the C++ side? Would the call
FusedAttnHelper().get_fused_attn_backend()give you the same gating effect?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if we are just interested in the gating effect, you are right. The
get_fused_attn_backend()will returnNVTE_No_Backendand then there's a catch-all at the end which basically skip the tests as there is no fused attn backend avalable.However, the reason for this to be here is to give a meaningful reason as to why a test is being skipped as compared to a generic "Unsupported inputs combination or device compute capability." message which does not qualify the reason for the skip. Unfortunately, on the JAX attn side we do not log the reason for disabling fused attn in the feature code like we have on the Pytorch side in
d_p_a/utils.py. So there is no way for the user to know why the test was skipped. Hence, we need to rely on test code to log this on the JAX side.I'd suggest we leave this in here for now. And when your PR for generating log messages in the C++ level when selecting the attn backend is ready, I can plumb it through onto the JAX side and then as part of that clean up, get rid of all the skip messages in check_configs()