[libcu++] Remove _view from the shared memory getter name #6997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
davebayer
reviewed
Dec 17, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pciolkosz
force-pushed
the
rename_shared_memory_option
branch
from
c2dbe7a to
e067be9
Compare
davebayer
approved these changes
Dec 18, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 25m: Pass: 100%/123 | Total: 21h 28m | Max: 39m 58s | Hits: 98%/229723See results here. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
* Remove _view from the shared memory getter * Forgot about cudax (cherry picked from commit c1c32c5)
Contributor
|
Successfully created backport PR for |
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Dec 23, 2025
* Remove _view from the shared memory getter * Forgot about cudax
pciolkosz
added a commit
that referenced
this pull request
Jan 6, 2026
) * Remove _view from the shared memory getter * Forgot about cudax (cherry picked from commit c1c32c5) Co-authored-by: pciolkosz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have
dynamic_shared_memorylaunch option type anddynamic_shared_memory_viewto get it from the config. We would like to move to two overloads ofdynamic_shared_memoryfunction, one that creates the option given type/size and one to get it from the config. This simplifies the interface and the overloads will never be ambitious.Because
dynamic_shared_memoryis currently a type, I had to rename the type todynamic_shared_memory_optionwith private constructors and instead introduce factory functions