fix(core): unit-test peer access planning without multi-GPU hardware#1773
Merged
cpcloud merged 1 commit intoNVIDIA:mainfrom Mar 24, 2026
Merged
fix(core): unit-test peer access planning without multi-GPU hardware#1773cpcloud merged 1 commit intoNVIDIA:mainfrom
cpcloud merged 1 commit intoNVIDIA:mainfrom
Conversation
Extract the peer-access transition planning from DeviceMemoryResource so stale-state regressions can be covered on single-GPU systems. Keep the existing multi-GPU integration tests for end-to-end peer access behavior. Made-with: Cursor
This comment has been minimized.
This comment has been minimized.
Andy-Jost
approved these changes
Mar 24, 2026
Contributor
Andy-Jost
left a comment
Andy-Jost
left a comment
There was a problem hiding this comment.
Thanks for doing this, looks good!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceMemoryResource.peer_accessible_bytransition planning into a helper so the normalization and delta logic can be validated without multiple GPUsTest plan
pixi run -e default pytest tests/test_memory_peer_access_utils.py tests/test_memory_peer_access.py -qpixi run -e default pytest tests/memory_ipc/test_peer_access.py -qMade with Cursor