Skip to content

add an agency column to CPDB #2416

Draft
damonmcc wants to merge 1 commit into
mainfrom
dm-cpdb-budget-agencies
Draft

add an agency column to CPDB #2416
damonmcc wants to merge 1 commit into
mainfrom
dm-cpdb-budget-agencies

Conversation

@damonmcc

@damonmcc damonmcc commented Jun 5, 2026

Copy link
Copy Markdown
Member

related to NYCPlanning/ae-data-flow#172

adds a column from dcp_projecttypes_agencies.csv to the CPDB table ccp_commitments which gets exported as cpdb_planned_commitments.csv

builds on this branch

todos

probably will drop this change in favor of the more long-term fix of using dcp_managing_agencies_lookup in facdb

the new column works but the values in it probably don't align with dcp_managing_agencies_lookup used by FacDB. should either change the values in dcp_projecttypes_agencies.csv or try using dcp_managing_agencies_lookup for commitments agency values

why

agencyabbrev has longer acronymns than agencyacronym. and those longer acronymns are what all other data products use, espcially those defined in (dcp_managing_agencies_lookup)[https://github.com/NYCPlanning/data-engineering/blob/main/ingest_templates/dcp_managing_agencies_lookup.yml]

this is a temporary fix to give AE a better column to use for commitment agency data. this csv should probably be consolidated into CPDB's lookup_agency.csv or into the dataset dcp_managing_agencies_lookup

to get the full acronymns (e.g. NYCOCA not just OCA)
@damonmcc damonmcc changed the base branch from dm-pff-2026 to main June 5, 2026 16:46
@damonmcc damonmcc marked this pull request as draft June 5, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant