add an agency column to CPDB #2416
Draft
damonmcc wants to merge 1 commit into
Draft
Conversation
to get the full acronymns (e.g. NYCOCA not just OCA)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to NYCPlanning/ae-data-flow#172
adds a column from
dcp_projecttypes_agencies.csvto the CPDB tableccp_commitmentswhich gets exported ascpdb_planned_commitments.csvbuilds on this branch
todos
probably will drop this change in favor of the more long-term fix of using
dcp_managing_agencies_lookupin facdbthe new column works but the values in it probably don't align with
dcp_managing_agencies_lookupused by FacDB. should either change the values indcp_projecttypes_agencies.csvor try usingdcp_managing_agencies_lookupfor commitments agency valueswhy
agencyabbrevhas longer acronymns thanagencyacronym. and those longer acronymns are what all other data products use, espcially those defined in (dcp_managing_agencies_lookup)[https://github.com/NYCPlanning/data-engineering/blob/main/ingest_templates/dcp_managing_agencies_lookup.yml]this is a temporary fix to give AE a better column to use for commitment agency data. this csv should probably be consolidated into CPDB's
lookup_agency.csvor into the datasetdcp_managing_agencies_lookup