Conversation
github-actions
Bot
added
documentation
Exeloo
changed the base branch from
main
to
refactor/change-start-cmd-to-new-archi
September 13, 2026 22:56
Exeloo
added this pull request to stack #221
September 13, 2026 22:56
github-actions
Bot
removed
documentation
MartinFillon
requested changes
Sep 14, 2026
Comment on lines
30
to
+33
| it("rejects with code 'load-failed' when the file throws while loading", async () => { | ||
| const error = await parseConfig(fixture("throwing-config.ts")).catch((e) => e); | ||
| expect(error).toMatchObject({ constructor: ConfigParseError, code: "load-failed" }); | ||
| expect(error.cause).toBeInstanceOf(Error); | ||
| expect(error.message).toContain("boom"); |
Contributor
There was a problem hiding this comment.
what is this test ? and especially the error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor create command to fit the new architecture.
The command should no longer run at the root of a workspace but in the sub folders (where config.type = client, server or lib)
How do you test this PR?