Harden admin-upload-media base64 normalization - #517
Merged
Conversation
Normalize content before strict decode (strip whitespace, recover space-substituted +, accept base64url), document JSON-arg usage for agents, and cover the recovery paths in AdminUploadMediaTest.
shanerbaner82
force-pushed
the
feature/admin-mcp-upload-base64-normalize
branch
from
September 12, 2026 19:39
e439974 to
cac1760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin-upload-mediabase64 inAdminArticleMediaService::storeHeroFromBase64before strictbase64_decode: strip whitespace, recover+mangled to spaces, accept base64url (-/_), keep rejectingdata:URIs.contentas a JSON string arg (raw base64, prefer WebP, heroes usedirectory: "blog/heroes"with slug/article_id, don’t put base64 in prose).data:URI rejection (invalid base64 error notes transport mangling).Test plan
vendor/bin/pint --dirtyphp -d memory_limit=512M vendor/bin/phpunit --filter=AdminUploadMediaTest(16 tests green)