Add integration test suite for Java code generator #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same approach as for `Kotlin2CodeGenTest` with a few differences: - Test cases are grouped by topic/area, so that it is easier to run just the required subset of related test cases. - Test case for underscore fields, which was inlined into `Kotlin2CodeGenTest`, is added as a separate test case into the `misc` package. Use `com.netflix.graphql.dgs.codegen.java` package for the test cases to avoid any accidental name clashes with the classes from the integration test suite for Kotlin code generator. Refactor the parametrized test logic, so that it works with the paths relative to the test sources root directory, rather than relying only on the parent package/directory. Resolve the issue with the client API generation for the cases when a reserved keyword is used as an input field name. Sanitize the input variable name, so that the generated Java code can be compiled.
illegal
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same approach as for
Kotlin2CodeGenTestwith a few differences:Kotlin2CodeGenTest, is added as a separate test case into themiscpackage.Use
com.netflix.graphql.dgs.codegen.javapackage for the test cases to avoid any accidental name clashes with the classes from the integration test suite for Kotlin code generator.Refactor the parametrized test logic, so that it works with the paths relative to the test sources root directory, rather than relying only on the parent package/directory.
Resolve the issue with the client API generation for the cases when a reserved keyword is used as an input field name. Sanitize the input variable name, so that the generated Java code can be compiled.