Skip to content

refactor(l1): implement universal types for l1#3408

Draft
MaksymMalicki wants to merge 6 commits intomainfrom
maksym/types-l1-addr-hash
Draft

refactor(l1): implement universal types for l1#3408
MaksymMalicki wants to merge 6 commits intomainfrom
maksym/types-l1-addr-hash

Conversation

@MaksymMalicki
Copy link
Copy Markdown
Contributor

@MaksymMalicki MaksymMalicki commented Feb 2, 2026

This PR introduces new universal l1 types:

  • l1hash
  • l1address
    That are meant to replace the types from go-ethereum/common package. They are based on holiman/uint256 package and are fully backward compatible.

This PR already includes the integration of the new types with Juno.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 68.32740% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.54%. Comparing base (a2867a2) to head (81f0965).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
l1/types/u256.go 55.38% 20 Missing and 9 partials ⚠️
l1/types/ctors.go 65.00% 9 Missing and 5 partials ⚠️
l1/types/address.go 69.44% 9 Missing and 2 partials ⚠️
rpc/v8/l1.go 68.18% 5 Missing and 2 partials ⚠️
l1/types/hash.go 76.92% 5 Missing and 1 partial ⚠️
rpc/v9/l1.go 70.00% 4 Missing and 2 partials ⚠️
rpc/v10/estimate_fee.go 0.00% 4 Missing ⚠️
l1/eth_subscriber.go 50.00% 3 Missing ⚠️
rpc/v8/estimate_fee.go 0.00% 3 Missing ⚠️
rpc/v9/estimate_fee.go 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3408      +/-   ##
==========================================
- Coverage   75.57%   75.54%   -0.03%     
==========================================
  Files         378      384       +6     
  Lines       34819    35023     +204     
==========================================
+ Hits        26313    26459     +146     
- Misses       6660     6690      +30     
- Partials     1846     1874      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaksymMalicki MaksymMalicki marked this pull request as draft February 3, 2026 15:39
@MaksymMalicki MaksymMalicki force-pushed the maksym/types-l1-addr-hash branch from b7eb638 to e672b87 Compare February 11, 2026 14:31
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant