refactor(l1): implement universal types for l1#3408
Draft
MaksymMalicki wants to merge 6 commits intomainfrom
Draft
refactor(l1): implement universal types for l1#3408MaksymMalicki wants to merge 6 commits intomainfrom
l1#3408MaksymMalicki wants to merge 6 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3408 +/- ##
==========================================
- Coverage 75.57% 75.54% -0.03%
==========================================
Files 378 384 +6
Lines 34819 35023 +204
==========================================
+ Hits 26313 26459 +146
- Misses 6660 6690 +30
- Partials 1846 1874 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b7eb638 to
e672b87
Compare
Contributor
|
This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new universal l1 types:
That are meant to replace the types from
go-ethereum/commonpackage. They are based onholiman/uint256package and are fully backward compatible.This PR already includes the integration of the new types with Juno.