fix: return flat JSON list from /v1/models endpoint#180
Open
jcabrero wants to merge 1 commit intofeat/rust-migrationfrom
Open
fix: return flat JSON list from /v1/models endpoint#180jcabrero wants to merge 1 commit intofeat/rust-migrationfrom
jcabrero wants to merge 1 commit intofeat/rust-migrationfrom
Conversation
The e2e test expects a plain JSON array of model objects, not an OpenAI-style wrapper with "object" and "data" keys. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/modelsendpoint to return a flat JSON array of model objects instead of an OpenAI-style{"object": "list", "data": [...]}wrapper.test_models_endpoint) assertsisinstance(response.json(), list)and readsmodel.get("id")directly from items, so the response must be a plain list.ModelMetadataalready has anidfield, so no domain changes were needed.Test plan
cargo check --workspacepassescargo test --workspacepasses (3/3 tests)🤖 Generated with Claude Code