fix: align credit service client with nilauth-credit API#181
Open
jcabrero wants to merge 1 commit intofeat/rust-migrationfrom
Open
fix: align credit service client with nilauth-credit API#181jcabrero wants to merge 1 commit intofeat/rust-migrationfrom
jcabrero wants to merge 1 commit intofeat/rust-migrationfrom
Conversation
Update endpoints, request/response formats, and trait signatures to match the actual nilauth-credit service API. Remove unused Bearer token authentication from the credit client since nilauth authenticates via credential keys in request bodies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/credential/validate,/v1/balance/lock/{public,private},/v1/balance/unlock)credential_key,credential,amount,real_cost)CreditService::lock_creditstrait signature to acceptcredential+is_publicinstead ofuser_id(the nilauth API authenticates via credential keys in request bodies)MeteringContextto carry credential and is_public instead of user_idTest plan
cargo check --workspacepassescargo test --workspacepasses (3 tests)cargo fmtandcargo clippyclean🤖 Generated with Claude Code