#4238 reschedule meetings#4257
Conversation
staysgt
left a comment
staysgt
left a comment
There was a problem hiding this comment.
Looks good so far! Left a few comments, and one more thing:
- When I go to reschedule an event, it should show in the same time range as originally selected to reschedule it to. For example, when I originally create the event, I select the time range as June 2-8. When I schedule the event for June 5 and then go to reschedule it, it only lets me reschedule in the range June 5-11, rather than the original range of June 2-8.
|
|
To do the fixed day range, I added a field to event called "previousDate" to see if there was an original time scheduled for the event that then is used when rescheduling |
staysgt
left a comment
staysgt
left a comment
There was a problem hiding this comment.
For the addition of previousDate into the schema, I think that we can instead just have initialDateScheduled keep track of this. This would work by updating the scheduleEvent service function so that initialDateScheduled defaults to being initialDateScheduled and falls back to startTime if there is no initialDateScheduled. And then you'll also need to update availabilityUrl in EventClickPopup.tsx to correctly show the initialDateScheduled date in the url, which is what it uses to populate the days shown in availability view
|
I added the changes. I think the line |
staysgt
left a comment
staysgt
left a comment
There was a problem hiding this comment.
Looking good, just a few more comments!
There was a problem hiding this comment.
Since we got rid of this you can delete this file and the folder its in
Removed unused import of isSameDay function.
staysgt
left a comment
staysgt
left a comment
There was a problem hiding this comment.
Really good job! One more small thing
| scheduledOrRescheduled + | ||
| ` for *${drTime}* ${location} by ${drSubmitter}`; | ||
| const docLink = event.questionDocumentLink ? `<${event.questionDocumentLink}|Doc Link>` : ''; | ||
| const threadMsg = `${mentionPrefix}This event has been Scheduled! \n` + docLink; |
There was a problem hiding this comment.
On line 519 can you update threadMsg to say scheduled/rescheduled depending on which it is
Refactor thread message construction for clarity.
2 participants
Changes
The creator of an event can now reschedule an event after is it scheduled.
This change is then notified on slack to the relevant users.
Additional change: Tooltip notifications added to icons in an event popup.
Notes
Any other notes go here
Test Cases
Screenshots
Rescheduling on event popup
Confirming Reschedule
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4238