Skip to content

feat: adds reusable actions#296

Open
baywet wants to merge 77 commits into
OAI:mainfrom
baywet:feat/action-templates
Open

feat: adds reusable actions#296
baywet wants to merge 77 commits into
OAI:mainfrom
baywet:feat/action-templates

Conversation

@baywet

@baywet baywet commented Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This pull request adds reusable actions.

closes #238

Reusable actions are a much simpler iteration of anything previously proposed/iterated on:

  • component actions that can define any field that are available in actions today EXCEPT FOR the target
  • reference objects that have at least $ref and target in the actions array
  • reference object MAY also override anything from the referenced reusable action (copy/update/remove/description)

This iteration is better than earlier proposals because it's as simple as we can possibly make it. (no matrix, no variables, no string interpolation, etc...)

@baywet baywet added this to the Release 1.2 milestone Feb 18, 2026
@baywet baywet requested review from handrews, karenetheridge, lornajane, mikekistler, mkistler and ralfhandl and removed request for mkistler February 18, 2026 18:37
@ralfhandl

ralfhandl commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

I like the general direction.

@baywet

baywet commented Feb 24, 2026

Copy link
Copy Markdown
Member Author

Feedback from the meeting from both @lornajane and @ralfhandl :

  • add a peer block to parameters for the environment variables, this allows to set defaults and "declare" which variables are used. But this declaration is optional.
  • add a peer "actions" in the components, that's defined as everything except for the target. So people can specify the target on reference. Reusable actions may use action templates in turns.

@baywet
feat: adds string literal replacement syntax
38198c9 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
feat: adds high level definitions for templates and templates parameters
74f3a40 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
feat: adds the action template reference object
2f2fbcc 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
docs: adds an example for the action templates
77d9e4f 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
feat: adds reusable actions to the components
5633f57 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
feat: adds environment variables template
06a21c9 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet baywet force-pushed the feat/action-templates branch from e709bde to 06a21c9 Compare February 25, 2026 15:19
@baywet baywet changed the title feat: adds action templates feat: adds action templates and reusable actions Feb 25, 2026
ralfhandl
ralfhandl reviewed Feb 25, 2026
View reviewed changes

@ralfhandl ralfhandl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly wording and capitalization

Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
baywet and others added 3 commits February 25, 2026 11:37
@baywet @ralfhandl
chore: capitalization fixes
553fca8 
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
@baywet @ralfhandl
chore: typo fixes
9329227 
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
@baywet @ralfhandl
fix: case sensitive environment variable
d01be1e 
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
handrews
handrews previously requested changes Feb 25, 2026
View reviewed changes
Comment thread versions/1.2.0-dev.md Outdated
@baywet baywet requested a review from ralfhandl February 25, 2026 18:56
baywet added 3 commits March 3, 2026 08:33
@baywet
feat: merges reusable actions
0b71e07 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
Merge branch 'feat/action-templates' of https://github.com/baywet/Ove…
beeeab0 
…rlay-Specification into feat/action-templates

Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
fix: updates wording for references definition
e64846a 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet

baywet commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

@ralfhandl @lornajane I pushed another update a couple of minutes ago. I wasn't happy about the whole reusable actions vs action templates kind of thing. After chatting with @mikekistler internally I realized we could simply define a an action template reference object as "you can override anything from the resolved template in the reference" like JSON schema does to some extent. And keep things extra simple.

Let me know what you think!

@baywet baywet requested review from mikekistler and ralfhandl June 4, 2026 17:05
ralfhandl
ralfhandl reviewed Jun 5, 2026
View reviewed changes
Comment thread schemas/v1.2-dev/schema.yaml Outdated
@baywet baywet requested a review from ralfhandl June 5, 2026 16:35
ralfhandl
ralfhandl previously approved these changes Jun 7, 2026
View reviewed changes
lornajane
lornajane reviewed Jun 7, 2026
View reviewed changes

@lornajane lornajane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a more detailed pass at it this time, added a few comments for things we should take a second glance at (especially considering how much refactoring has been done on this one) but nothing fundamental I promise!

Comment thread versions/1.2.0-dev.md
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md
Comment thread versions/1.2.0-dev.md
Comment thread tests/v1.2-dev/fail/reusable-action-reference-unescaped-component-key.yaml Outdated
Comment thread tests/v1.2-dev/fail/reusable-action-reference-unescaped-tilde-component-key.yaml Outdated
Comment thread tests/v1.2-dev/pass/components-extensions.yaml Outdated
Comment thread tests/v1.2-dev/pass/reusable-action-empty-fields.yaml
Comment thread tests/v1.2-dev/pass/reusable-action-extensions.yaml
baywet and others added 5 commits June 8, 2026 09:52
@baywet
fix: wrong ident for example
4f30a3d 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
fix: wrong indent for action description
9e4c18a 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
fix: adds missing content keyword
031eb9d 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
docs: adds a short description to reference object
3515bf7 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
fix: wrap reusable action fields in invalid ref fixtures
729daf0 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baywet and others added 2 commits June 8, 2026 10:17
@baywet
fix: reference reusable actions in extension fixtures
66dcdb6 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@baywet
docs: makes the recap less specific to the data structure
a8c1719 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet

baywet commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@lornajane thanks for the great suggestions here! I took the liberty of resolving the ones that I considered trivial. Let me know what you think!

@baywet baywet requested a review from lornajane June 8, 2026 14:29
mikekistler
mikekistler previously approved these changes Jun 8, 2026
View reviewed changes

@mikekistler mikekistler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

ralfhandl
ralfhandl requested changes Jun 16, 2026
View reviewed changes
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
Comment thread versions/1.2.0-dev.md Outdated
@baywet @ralfhandl
chore: Apply suggestions from code review
60dfec0 
Co-authored-by: Ralf Handl <ralf.handl@gmail.com>
@baywet baywet requested review from mikekistler and ralfhandl June 16, 2026 12:04
mikekistler
mikekistler previously approved these changes Jun 16, 2026
View reviewed changes

@mikekistler mikekistler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

baywet added 3 commits June 16, 2026 11:08
@baywet
fix: aligns terminology for Overlay (not document)
d79f0e5 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
tests: adds a comment to the clarify the test intent
8a04774 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet
fix: only description is allowed next to $ref
d85d264 
Signed-off-by: Vincent Biret <vincentbiret@hotmail.com>
@baywet baywet requested a review from mikekistler June 16, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karenetheridge karenetheridge Awaiting requested review from karenetheridge

@handrews handrews Awaiting requested review from handrews

@lornajane lornajane Awaiting requested review from lornajane

@ralfhandl ralfhandl Awaiting requested review from ralfhandl

@mikekistler mikekistler Awaiting requested review from mikekistler

1 more reviewer

@nasha4 nasha4 nasha4 approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.2

Development

Successfully merging this pull request may close these issues.

7 participants

@baywet @ralfhandl @mikeschinkel @lornajane @handrews @mikekistler @nasha4