Skip to content

[18.0][FIX] report_csv: self is model cls here - must use report_sudo for encoding and encode_error_handling#1143

Open
wpichler wants to merge 1 commit intoOCA:18.0from
wpichler:18.0-fix-report_csv_encoding_in_context
Open

[18.0][FIX] report_csv: self is model cls here - must use report_sudo for encoding and encode_error_handling#1143
wpichler wants to merge 1 commit intoOCA:18.0from
wpichler:18.0-fix-report_csv_encoding_in_context

Conversation

@wpichler
Copy link

@wpichler wpichler commented Mar 9, 2026

Problem got visible as soon as i tried to use such a report within a mail.template. mail.template likes binary attachment, so i did set an encoding. But got the same error, so i found this bug...

@hbrunn hbrunn changed the title [FIX] self is model cls here - must use report_sudo for encoding and encode_error_handling [18.0][FIX] report_csv: self is model cls here - must use report_sudo for encoding and encode_error_handling Mar 13, 2026
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please prefix your PRs with the version and the module name as I did in the edit.

CI failure seems unrelated, but must be fixed nonetheless before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants