Refactor of the serialize and to_serializable function#270
Draft
raphaelahrens wants to merge 2 commits intoOWASP:masterfrom
Draft
Refactor of the serialize and to_serializable function#270raphaelahrens wants to merge 2 commits intoOWASP:masterfrom
serialize and to_serializable function#270raphaelahrens wants to merge 2 commits intoOWASP:masterfrom
Conversation
Contributor
Author
|
Hey so I looked into a bit more and came up with something that gives the same report to the original. Main reason why this is just a draft is that I also have the feeling that the sql report is missing some attributes. |
Contributor
Author
|
@izar any opinion? |
izar
approved these changes
Aug 20, 2025
Collaborator
|
Sorry, I have been simply overwhelmed since the beginning of the year. Yeah, this looks good to continue. |
raphaelahrens
force-pushed
the
serialize_rewrite
branch
from
763e869 to
02f0409
Compare
It was possible to inject html markup in the label of a dot node. This lead to the error observed in OWASP#278. This fix is currently only for the label attribute. Other attribute might be affected as well.
This commit tries to tackle OWASP#268 and rewrite the `serialize` function to handle less class specific cases and move it into the single dispatch function `to_serializable`.
raphaelahrens
force-pushed
the
serialize_rewrite
branch
from
02f0409 to
2b9d558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit tries to tackle #268 and rewrite the
serializefunction to handle less class specific cases and move it into the single dispatch functionto_serializable.