Skip to content

core: revert debugging and chain-split-halt changes#4390

Merged
obol-bulldozer[bot] merged 7 commits intomainfrom
pinebit/revert-debugging-19
Mar 11, 2026
Merged

core: revert debugging and chain-split-halt changes#4390
obol-bulldozer[bot] merged 7 commits intomainfrom
pinebit/revert-debugging-19

Conversation

@pinebit
Copy link
Collaborator

@pinebit pinebit commented Mar 11, 2026

Summary

  • Revert temporary debugging commits (extra QBFT logging, recv buffer debug, runInstance logging, new deadliner)
  • Revert chain-split-halt removal (restore the feature)

category: misc
ticket: none

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 60.31128% with 102 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.37%. Comparing base (aea4746) to head (7f48301).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
core/consensus/qbft/qbft.go 26.66% 75 Missing and 2 partials ⚠️
core/deadline.go 76.27% 12 Missing and 2 partials ⚠️
core/qbft/qbft.go 88.63% 10 Missing ⚠️
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4390      +/-   ##
==========================================
- Coverage   56.67%   56.37%   -0.31%     
==========================================
  Files         237      237              
  Lines       31681    31687       +6     
==========================================
- Hits        17956    17863      -93     
- Misses      11438    11538     +100     
+ Partials     2287     2286       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinebit pinebit added merge when ready Indicates bulldozer bot may merge when all checks pass labels Mar 11, 2026
@obol-bulldozer obol-bulldozer bot merged commit 5677c99 into main Mar 11, 2026
12 of 14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/revert-debugging-19 branch March 11, 2026 19:23
KaloyanTanev pushed a commit that referenced this pull request Mar 11, 2026
## Summary
- Revert temporary debugging commits (extra QBFT logging, recv buffer debug, runInstance logging, new deadliner)
- Revert chain-split-halt removal (restore the feature)

category: misc
ticket: none
KaloyanTanev added a commit that referenced this pull request Mar 11, 2026
* core: revert debugging and chain-split-halt changes (#4390)

## Summary
- Revert temporary debugging commits (extra QBFT logging, recv buffer debug, runInstance logging, new deadliner)
- Revert chain-split-halt removal (restore the feature)

category: misc
ticket: none

* app: improved loki client (#4389)

Improved loki client: buffered input channel + dropping and counting entries when the buffer is full.

category: refactor
ticket: none

---------

Co-authored-by: Andrei Smirnov <andrei@obol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants