ArgoCD: Make RepositoryAdapter more generic so it can be reused in new git steps#1865
Open
ArgoCD: Make RepositoryAdapter more generic so it can be reused in new git steps#1865
Conversation
…teParser Also fix dangling references in TransformAndCommitToGitCommand left by the removed files: drop the stale CommitWorkspaceToGitRepositoryConvention AddRange block and correct pathToPackage -> packageFile so the build is clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Connection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
flin-8
reviewed
Apr 2, 2026
| public delegate FileUpdateResult RepositoryMutator(string workingDir); | ||
|
|
||
| // New generic overload — used by CommitToGitConvention and (after Task 3) ArgoCD callers | ||
| public SourceUpdateResult Process(string repoUrl, string targetRevision, RepositoryMutator mutator) |
Contributor
There was a problem hiding this comment.
Maybe SourceUpdateResult needs to be renamed? It's not very generic atm
Contributor
Author
There was a problem hiding this comment.
What would you think about "RepositoryUpdates"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the RepositoryAdapter takes argo-specific types, which makes it hard to reuse in the new commit-to-git step (which would be nice to reuse the existing git-commit type logic).
This PR removes the Argo specific aspects - but leaves other classes etc. in their existing location.