Run Prettybot's cleanup with the repo's profile - #347
Merged
matt-richardson merged 1 commit intoAug 12, 2026
Conversation
The container's prettybot.sh runs cleanupcode without --profile, which applies ReSharper's built-in Full Cleanup rather than the Octopus Deploy profile in OctoVersion.sln.DotSettings. Also label Prettybot PRs autoapprove so the approve-and-merge workflow runs, and look for superseded PRs under the account that actually opens them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
matt-richardson
deleted the
mattrichardson/prettybot-profile-and-autoapprove
branch
August 12, 2026 05:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Prettybot has never applied this repo's ReSharper settings. The container's
/scripts/prettybot.shrunsjb cleanupcode "$SOLUTIONFILE"with no--profile, and perjb cleanupcode --helpthat means "Full cleanup profile is used if nothing specified." No settings key changes the CLI default — the profile has to be passed on the command line.So the
Octopus Deployprofile inOctoVersion.sln.DotSettingswas being ignored in favour of ReSharper's built-in Full Cleanup. Full Cleanup includes "Arrange argument style", which is why #346 reverted the namedmaxVersionLength:arguments back to positional.Prettybot PRs were also never auto-approved, because
renovate-approve-pr.yamlgates on theautoapprovelabel andgh pr createpassed no label. The actor half of that condition already matched. Separately, the query that closes superseded PRs looked forgithub-actions[bot]while the PRs are opened byteam-builds-bot, so it never found anything and old Prettybot PRs accumulated.Notes
Measured against the real
tool-resharper-cli:latestcontainer on a clean checkout ofmain: the current command strips all 17 named-argument call sites and touches 5 files; with--profilenone are stripped and 2 files are touched.Invoking
jbdirectly means this repo no longer uses the sharedprettybot.sh. That script is still wrong for every other repo using the container — DPT-3156 covers fixing it centrally, which is a deliberate org-wide behaviour change rather than something to slip in here.Applying the profile is not a no-op. It still reorders type members, rewraps the
CapPreReleaseTagarguments underMAX_INVOCATION_ARGUMENTS_ON_LINE=4, and strips a trailing newline. Expect a smaller Prettybot PR after this merges, not an empty one, and #346 should be closed and left to regenerate.Linear: DPT-3156, DPT-3157
🤖 Generated with Claude Code