feat: [SDK-5033] add shared Turbine feature-flags client - #19
Open
abdulraqeeb33 wants to merge 1 commit into
Open
feat: [SDK-5033] add shared Turbine feature-flags client#19abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
Move path validation, JSON parse, and fetch orchestration into com.onesignal.features so Android and iOS hosts can reuse one client. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.onesignal.featuresso Android and iOS hosts can reuse one client.IFeatureFlagsHttp(same port/adapter shape asILogHttpSender). Caching, foreground refresh, and console logging stay on the platform.ar/kmp-feature-flags-client(never pushed) and lands it againstmain.Linear: https://linear.app/onesignal/issue/SDK-5033/move-turbine-feature-flags-client-into-shared-kmp
Test plan
./gradlew :kmp:testDebugUnitTest :kmp:iosSimulatorArm64Test spotlessCheckFeatureFlagsBackendServicearoundFeatureFlagsClientand pin the KMP submodule to this branch (adapter is in a local stash on OneSignal-Android-SDK)RemoteFeatureFlagsFetchOutcomeandJsonObjectmetadata at the Obj-C boundary (called out in review)Made with Cursor