[C#][generichost] Fix enum generation#24069
Open
Killianven wants to merge 1 commit into
Open
Conversation
Previous version cause the enum variable wrote with a jump. So the project won't compile ex : myEnum RawValue The solution write it well myEnumRawValue
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
vgilabert
approved these changes
Jun 19, 2026
vgilabert
left a comment
vgilabert
left a comment
There was a problem hiding this comment.
Had the same issue, this fixed the problem
Hilifrio
approved these changes
Jun 19, 2026
Member
|
thanks for the PR please follow step 3 in the PR checklist to update the samples so as to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/27835579713/job/82583767366?pr=24069 cc @devhl-labs |
devhl-labs
reviewed
Jun 21, 2026
| {{#lambda.copyText}} | ||
| {{#lambda.camelcase_sanitize_param}}{{name}}{{/lambda.camelcase_sanitize_param}} | ||
| {{/lambda.copyText}} | ||
| {{#lambda.copyText}}{{#lambda.camelcase_sanitize_param}}{{name}}{{/lambda.camelcase_sanitize_param}}{{/lambda.copyText}} |
Contributor
There was a problem hiding this comment.
Stacking these on one line will introduce unintended whitespace. There is already a trim lambda. You can add it to the abstract C# class and use it here.
devhl-labs
reviewed
Jun 21, 2026
| {{/lambda.trimTrailingWithNewLine}} | ||
| } | ||
| } No newline at end of file | ||
| } |
Contributor
There was a problem hiding this comment.
Please try not to make unintended whitespace changes like this added line break.
devhl-labs
suggested changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the template genericHost to generate c# client api,
Previous version cause the enum variable wrote with a jump in the JsonConverter.mustach, So the project won't compile
ex :
myEnum
RawValue
The solution write it well
myEnumRawValue
Summary by cubic
Fix enum name generation in the C#
generichosttemplate by removing an unintended line break inJsonConverter.mustache. Names like myEnumRawValue are now emitted on one line instead of being split (myEnum + newline + RawValue), so generated projects compile.Written for commit adc181b. Summary will update on new commits.