Skip to content

Move shared git push template to _common - #24565

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
ChihweiLHBird:centralized-git_push.sh
Aug 10, 2026
Merged

Move shared git push template to _common#24565
wing328 merged 1 commit into
OpenAPITools:masterfrom
ChihweiLHBird:centralized-git_push.sh

Conversation

@ChihweiLHBird

@ChihweiLHBird ChihweiLHBird commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Consolidate 38 byte-identical git_push.sh.mustache templates into the existing _common template directory.

Generators continue to resolve the script through the standard common-template fallback, while generator-specific variants remain unchanged.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Consolidated 38 duplicate git_push.sh.mustache templates into the shared _common/git_push.sh.mustache to reduce duplication and simplify maintenance. Generators continue to resolve the script via the common-template fallback; generator-specific overrides are unchanged.

Written for commit 8abfd56. Summary will update on new commits.

Review in cubic

Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 38 files

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

@wing328
wing328 merged commit 9b9e7f0 into OpenAPITools:master Aug 10, 2026
15 checks passed
@wing328 wing328 added this to the 7.25.0 milestone Aug 10, 2026
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Aug 10, 2026
@ChihweiLHBird
ChihweiLHBird deleted the centralized-git_push.sh branch August 10, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants