fix desktop navigation boundary#340
Open
snowopsdev wants to merge 2 commits into
Open
Conversation
…into fix/desktop-navigation-boundary # Conflicts: # apps/desktop/src/renderer/src/components/FilesTabView.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
will-navigateand main-framewill-redirectattempts, while preserving the existing allowlisted external-open behavior.Closes #339
Why
Workspace Markdown is untrusted content rendered inside the desktop app chrome. The app already denied
window.openattempts, but top-level navigation and redirects also need to be guarded so a clicked Markdown link cannot replace the trusted app document in the main BrowserWindow.Test Plan
pnpm --filter @open-codesign/desktop exec vitest run src/main/navigation-policy.test.ts src/renderer/src/lib/markdown-links.test.ts src/main/open-external.test.tspnpm --filter @open-codesign/desktop typecheckpnpm --filter @open-codesign/desktop testpnpm typecheckpnpm lintpnpm test