Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Contributor
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
|
📁 PR Artifacts Notice This PR contains a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
Tested a full canvas setup through the agent.
AGENT:
Why
DockerWorkspaceis a locally managed workspace and its SDK client connects through127.0.0.1, but Docker currently publishes its API and optional VS Code ports on every host interface. Aligning the publication address with the client address keeps the default networking behavior local to the machine.When a session API key is forwarded into the container, the workspace client also needs to retain that key so its HTTP and WebSocket requests use the same configuration.
Summary
Issue Number
OSS-10566
How to Test
Focused checks:
Result: 22 tests passed; Ruff lint and formatting checks passed. The test suite still reports its pre-existing
DockerWorkspace.__del__cleanup warning in unrelated lifecycle tests.End-to-end Docker smoke test:
Observed output:
The generated launch command retained
--host 0.0.0.0 --port 8000inside the container and used-p 127.0.0.1:36957:8000on the Docker host.Agent Canvas end-to-end validation:
The conversation ran through the Canvas API and UI, executed the terminal action in its Docker conversation runtime, wrote the mounted workspace file, returned
canvas-docker-e2e, and rendered the completed result on the conversation page.Video/Screenshots
Successful Agent Canvas conversation using the Docker conversation runtime:
Design Doc
Not needed for this focused change. It follows the existing loopback publication pattern used by the conversation-container runtime.
Type
Notes
The agent process must continue listening on
0.0.0.0inside the container so Docker's bridge forwarding can reach it. The loopback restriction belongs on the host-side-pmapping.This pull request was created by an AI agent (OpenHands) on behalf of the user.
🐳 Agent Server images for this PR — GHCR package, pull/run commands, and all pushed tags (click to expand)
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdkpython-node-runtimepython-node-runtimepython-node-runtimegolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:90b9d8c-pythonRun
All tags pushed for this build
About Multi-Architecture Support
90b9d8c-python) is a multi-arch manifest supporting both amd64 and arm6490b9d8c-python-amd64) are also available if needed