Repository navigation
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
safal207
marked this pull request as ready for review
October 13, 2026 10:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
Why
The existing three-action batch test checks the sets of action IDs, but uniform analyzer results let incorrectly associated values pass. Strengthen it so moving one action's risk or details to another action ID fails the test. This is the focused coverage follow-up requested in Arian's comment after #5182.
Summary
tool_call_iddetail markers in the existing batch test.ActionEvent.id, retain the acting model's LOW self-label invariant, and close the conversation infinally.tests/sdk/agent/test_security_analysis_event.py(+35/-8). No production behavior or public API changes.Issue Number
Refs #4259; tests-only follow-up to #5182.
How to Test
Validated on Windows LIS, Python 3.13.16, with frozen workspace dependencies at base
7bd668c9ab74f62c85745cd95adb503f53e7228bplus this patch. SetOH_PERSISTENCE_DIRto an isolated writable directory before importing the SDK.Video/Screenshots
No visual changes. Local evidence includes command logs, JUnit XML, before/after file hashes, and the replayable negative-control script. These artifacts are prepared separately from the native tests-only patch.
Design Doc
Not applicable to this small coverage change.
Type
Notes
This validates the
Agent.steppath with mocked completion and a no-op tool. It establishes test sensitivity to value-to-ID permutations; it does not establish a production authorization defect or expand confirmation enforcement. Full CI, live-model execution, and restart durability were not run for this contribution.