Conversation
- ADUserAccountControl's private constructor assigned uac to both fields, so isAccountLockOut()/isPasswordExpired() never read the real msDSUac value from AD's ms-DS-User-Account-Control-Computed attribute. - JavaScriptExecutorFactory accepted a ClassLoader but never applied it, unlike its Groovy sibling; JS scripts always ran under the ambient thread context classloader instead of the one requested by the caller. - OpenICFWebSocketCreator.unauthorized() dropped the specific reason it was passed and always sent the same generic explanation. Also removes dead OperationOptions/typeName parameters from private helpers (ActiveDirectoryChangeLogSyncStrategy.handleEvents, SchemaApiOpTests.getTestPropertyOrFail, CSVFileConnector findAccount/doDelete/doUpdate) and updates their call sites.
vharseko
added
java
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigated all 49 open
java/unused-parameterCodeQL alerts. 40 were dismissed on GitHub as false positive/won't-fix (interface/abstract method declarations, uniform dispatch signatures, TestNG DataProvider/Factory injection, Procrun stop(String[] args) convention, and public extensibility hooks). The remaining 9 pointed at real problems, fixed here:ADUserAccountControl: the private constructor assigneduacto both theuacandmsDSUacfields instead of keeping them separate, soisAccountLockOut()/isPasswordExpired()never read the real value of AD'sms-DS-User-Account-Control-Computedattribute.JavaScriptExecutorFactory: accepted aClassLoaderbut never applied it (unlike its Groovy sibling, which passes it intoGroovyShell). JS scripts always ran under the ambient thread context classloader instead of the one the caller requested. Fixed by scoping the thread context classloader aroundeval().OpenICFWebSocketCreator.unauthorized(): dropped the specificmessageit was passed and always sent the same generic rejection reason.Also removes genuinely dead
OperationOptions/typeNameparameters from private helpers and updates their call sites:ActiveDirectoryChangeLogSyncStrategy.handleEvents,SchemaApiOpTests.getTestPropertyOrFail,CSVFileConnector.findAccount/doDelete/doUpdate.Test plan
ADUserAccountControlTests,JavaScriptExecutorFactoryTests,UnauthorizedResponseTest— RED before the fix, GREEN after.mvn installonconnector-framework-internal,connector-framework-contract,connector-server-jetty,OpenICF-ldap-connector,OpenICF-csvfile-connector(incl. their existing test suites) — all green.