MAX_MACH update - #1250
Open
xjjiang wants to merge 38 commits into
Open
Conversation
…raft.Design.MAX_MACH
…raft.Design.MAX_MACH
…ume MAX_MACH != 1?
…ased mass subsystem
xjjiang
marked this pull request as ready for review
August 5, 2026 23:56
cmbenne3
requested changes
Aug 10, 2026
cmbenne3
left a comment
cmbenne3
left a comment
Contributor
There was a problem hiding this comment.
Couple of suggestions in addition to Ken's suggestion of removing some of the commented lines. Otherwise looks good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tasks Accomplished:
Mission.Constraints.MAX_MACHtoAircraft.design.MAX_MACH.Aircraft.design.MAX_MACHa variable instead of an option.max_machin GASP based mass subsystem byAircraft.design.MAX_MACH.test_GASP_mass_FLOPS_everything_else()ofsubsystems/test/test_premission.pyand I traced out the reason. This is no along a problem anymore after this parameter was converted to an Aviary variable. But it still may have affected other parameters. I added a note in the unit test.This is part of Issue #598
Related Issues
Backwards incompatibilities
None
AI Usage
None