Repository navigation
Fix Workflow pages and Layout Managers crashing on a fresh install - #102
t0mdavid-m wants to merge 2 commits into
Conversation
- Point the example data fallbacks at the mzML and FASTA files shipped in the default demo workspace; the old example-data/deconv and example-data/tnt paths do not exist, so the Workflow pages raised FileNotFoundError in any workspace without uploads. - Call page_setup() before the Layout Managers read st.session_state['workspace'], so opening them by direct link or after a refresh no longer raises KeyError. - Do not index an empty tool list in the parameter summary when no TOPP tool .ini has been written yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KyJg47YNaoYnCCj1QYkHEy
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
polars 2.0 removed the no-argument pl.count(), so CI, which installs the newest polars allowed by requirements.txt (>=1.0.0), failed test_nonempty_input_passes_through_binning. pl.len() exists since 0.20. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KyJg47YNaoYnCCj1QYkHEy
|
Generated by Claude Code |
Before: when FLASHApp was run from the repository, the FLASHDeconv and FLASHTnT Workflow pages crashed with
FileNotFoundError: example-data/deconv/example_lc_ms.mzMLin any workspace without uploads. Both Layout Managers crashed withKeyError: st.session_state has no key "workspace"when opened by direct link or after a refresh.After: the Workflow pages fall back to the example mzML and FASTA files that already ship in the default demo workspace, and the Layout Managers open from any link.
The example paths in
src/Workflow.pypointed atexample-data/deconv/andexample-data/tnt/, which are not in the repository. Fixing them revealed a third crash. When no TOPP tool has written its.iniyet, the parameter summary indexed an empty tool list, so that case is now guarded.How:
EXAMPLE_DATAand the FASTA fallback now point atexample-data/workspaces/default/.../input-files/.page_setup()moves above theFileManagersetup in both Layout Managers.export_parameters_markdown()checks for an empty list. The daily usability check had reported these 6 failures every day. Against this branch it passes all 26 page visits in a fresh workspace, a demo workspace and by direct link.pytest tests/passes (52 tests), and pylint--errors-onlyis clean on the changed files.🤖 Generated with Claude Code
https://claude.ai/code/session_01KyJg47YNaoYnCCj1QYkHEy
Generated by Claude Code