Update mod to release-20250330 #814
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Straight-up copied the one from OpenRA ModSDK.
As per OpenRA PR 21379.
As per OpenRA PR 21427.
OpenRA PR 21635.
penev92
force-pushed
the
update-to-20250330
branch
from
40164d6 to
ce3d79a
Compare
Mailaender
reviewed
Apr 24, 2025
Mailaender
reviewed
Apr 24, 2025
Mailaender
reviewed
Apr 24, 2025
Mailaender
reviewed
Apr 24, 2025
Mailaender
reviewed
Apr 24, 2025
…m loader OpenRA PR 21598.
OpenRA PR 21066.
OpenRA PR 21622.
OpenRA PR 20226.
- Move Voxel assets browser preview definitions from common to TS (OpenRA PR 21118). - Persist skirmish settings between sessions (OpenRA PR 21206). - Prevent community mods from warning on unused translations in the common assets (OpenRA PRs 21503, 21622). - Expose mod.yaml content to localisation (OpenRA PR 21601).
OpenRA PR 21623.
.\utility.cmd ra2 --update-mod release-20231010 --detailed --apply
OpenRA PR 21134. Run utility command --extract-chrome-strings. NOTE: This expects that there is a /fluent folder with a /chrome.ftl file in your mod!
OpenRA PR 21204? Run utility command --extract-yaml-strings.
Refinery.TickLifetime and TickVelocity were removed in OpenRA PR 20636 as they were apparently unused for a long, long time.
penev92
force-pushed
the
update-to-20250330
branch
from
ce3d79a to
316ae3d
Compare
Member
Author
|
Fixed several things and took the liberty to update AUTHORS. I have two follow-up PRs ready:
But I would prefer not to add them to this already quite sizable PR. |
Member
|
Crashes when I start with map |
Apparently it contained multiplayer maps, but we don't install it anyway.
To stop it from crashing due to a fence at the top tile row that is being projected outside the map bounds.
Member
Author
|
The problem was a fence at the topmost row of tiles, which was being projected outside of the map bounds. |
Mailaender
reviewed
May 7, 2025
Comment on lines
+89
to
+97
| // void INotifyHarvestAction.MovingToRefinery(Actor self, Actor refineryActor) | ||
| // { | ||
| // var iao = refineryActor.Trait<IAcceptResources>(); | ||
| // var targetCell = self.World.Map.CellContaining(iao.DeliveryPosition); | ||
| // if (destination != null && destination.Value != targetCell) | ||
| // ticksTillCheck = 0; | ||
| // refinery = refineryActor; | ||
| // destination = targetCell; | ||
| // } |
Mailaender
reviewed
May 7, 2025
Comment on lines
+119
to
+120
| // self.QueueActivity(new DeliverResources(self, refinery)); | ||
| // self.QueueActivity(new FindAndDeliverResources(self, refinery)); |
Member
There was a problem hiding this comment.
Delete it or keep it. We track the changes in revision control.
Mailaender
reviewed
May 7, 2025
| foreach (var kv in structuresSection) | ||
| { | ||
| var isDeployed = false; | ||
| // TODO: Add back isDeployed, |
Mailaender
reviewed
May 7, 2025
| spawn-claimed: 5, 5, 22, 22 | ||
| spawn-disabled: 5, 5, 22, 22 # TODO: Needs new artwork! | ||
| admin: 64, 5, 7, 5 | ||
| bot: 170, 51, 16, 16 # TODO: Needs new artwork! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Here we go again!)
Two things to note:
ChronoResourceDeliveryhere is broken because of the ongoing docking rework upstream , but I don't think it's worth adapting to the current WIP engine APIs until those settle to a semi-stable state.ImportRA2MapCommandmay have some regressions (I believe it doesn't import lamps after this update), but it deserves a full rewrite (as mentioned in Added a Red Alert 2 .map importer and terrain lighting #798 (comment)) based on Improve gen2 map importer OpenRA#20784, which I am already doing in a follow-up branch and would like to keep in a separate PR because this one is big enough.