Repository navigation
openrc-user: keep the notify fd out of the login shell's stdout - #1114
Open
CodingVoid wants to merge 1 commit into
Open
CodingVoid wants to merge 1 commit into
CodingVoid wants to merge 1 commit into
Conversation
spawn_openrc mapped the readiness pipe to the login shell's stdout, and openrc-user.sh later copied stdout to fd 3 before signalling. Anything a login shell startup file writes to stdout before openrc-user.sh reaches that line is mistaken for the readiness notification, which closes the read end. The real notification then dies with SIGPIPE and the user session is restarted until respawn-max is reached. Keep fd 3 as the notify pipe, send shell output to stderr, signal on fd 3 and close it before exec'ing the runlevel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawn_openrc mapped the readiness pipe to the login shell's stdout, and openrc-user.sh later copied stdout to fd 3 before signalling. Anything a login shell startup file writes to stdout before openrc-user.sh reaches that line is mistaken for the readiness notification, which closes the read end. The real notification then dies with SIGPIPE and the user session is restarted until respawn-max is reached.
Keep fd 3 as the notify pipe, send shell output to stderr, signal on fd 3 and close it before exec'ing the runlevel.