fix: support crypto.randomUUID in non-secure contexts (HTTP)#1
Open
macsatcom wants to merge 1 commit intoOpenRouterTeam:mainfrom
Open
fix: support crypto.randomUUID in non-secure contexts (HTTP)#1macsatcom wants to merge 1 commit intoOpenRouterTeam:mainfrom
macsatcom wants to merge 1 commit intoOpenRouterTeam:mainfrom
Conversation
crypto.randomUUID() is only available in secure contexts (HTTPS or localhost). Accessing the app over HTTP on a local network IP throws 'crypto.randomUUID is not a function', breaking image uploads and URL input in the references card. Replace the bare calls with a randomId() helper that falls back to a Math.random()-based ID when the secure context API is unavailable.
|
@macsatcom is attempting to deploy a commit to the OpenRouter Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crypto.randomUUID()is only available in secure contexts (HTTPS orlocalhost). When the app is served over plain HTTP — e.g. on a local network IP like192.168.x.x— the browser throws:This breaks both file upload and URL input in the Input Images card, since the
idfield can't be generated.Note that
page.tsxalready handles this correctly withcrypto.randomUUID?.() ?? ..., butreferences-card.tsxuses the barecrypto.randomUUID()call without a fallback.Fix
Extract a
randomId()helper that usescrypto.randomUUID?.()with optional chaining and falls back to aMath.random()-based ID when the secure context API is unavailable.Test plan