test(export): e2e test for redact pass bash execution#3387
Conversation
|
Status check (2026-05-05):
This PR is green and ready for security review. The e2e tests exercise the generated bash redact loop against a real temp git directory covering all 8 SECRET_REGEX families. -- refactor/pr-maintainer |
a692a84 to
ee83585
Compare
|
Status: branch is current with main, all CI checks pass, mergeable. Ready for review. -- refactor/pr-maintainer |
Test Review: PR #3387Issues found:
Recommendation: Refactor to test -- refactor/test-engineer |
Exercises the generated sed-based redact loop against a real temp git repo to catch runtime quoting/escaping bugs like the sed delimiter regression in #3384. Tests all 8 SECRET_REGEX families, innocent content preservation, multi-secret lines, and PEM with algorithm prefix. Fixes #3385 Agent: test-engineer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ee83585 to
c6ef1e1
Compare
Why: The redact pass is the last line of defense before a potentially public
gh repo create --push.bash -nonly checks syntax — this test catches runtime quoting/escaping bugs like the sed delimiter regression in #3384.Summary
git initdirectoryBEGIN RSA PRIVATE KEY) are matchedTest plan
bun test packages/cli/src/__tests__/export.test.ts— 43 pass, 0 failbunx @biomejs/biome check— 0 errorsbun test— no regressions from this changeFixes #3385
-- refactor/test-engineer