Skip to content

feat: Extend Swagger Coverage for controller OAuth2SummitOrderExtraQuestionTypeApiController #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andrestejerina97 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Extend Swagger Coverage for controller OAuth2SummitOrderExtraQuestionTypeApiController #432

andrestejerina97 wants to merge 4 commits into from
+821 −14

Conversation

@andrestejerina97
Copy link
Contributor

@andrestejerina97 andrestejerina97 commented Oct 22, 2025

@andrestejerina97 andrestejerina97 self-assigned this Oct 31, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller-oauthsummitorderextraquestionpicontroller branch from 9f24f64 to bc2dfd9 Compare December 5, 2025 21:19
@matiasperrone-exo matiasperrone-exo self-assigned this Dec 5, 2025
caseylocker
caseylocker requested changes Dec 6, 2025
View reviewed changes
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All endpoints lack security attributes even though they're OAUTH endpoints.
They should include the appropriate scopes.

@matiasperrone-exo
Copy link
Contributor

matiasperrone-exo commented Dec 8, 2025

@caseylocker thank you for your comments.

Tasks performed:

Added the following routes that were missing

  • GET /api/v1/summits/{id}/order-extra-questions → getAllBySummit (trait)
  • GET /api/v1/summits/{id}/order-extra-questions/{question_id} → get (trait)
  • GET /api/public/v1/summits/{id}/order-extra-questions → getAllBySummit (trait)

Files renamed

Missing security schema created

caseylocker
caseylocker approved these changes Dec 8, 2025
View reviewed changes
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Dec 9, 2025
@smarcet smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caseylocker caseylocker caseylocker approved these changes

Assignees

@smarcet smarcet

@matiasperrone-exo matiasperrone-exo

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andrestejerina97 @matiasperrone-exo @caseylocker @smarcet @matiasperrone