drop gettext from jruby gems #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this gem was likely added to support the (brief) module localization effort, in addition to fast_gettext, but it's probably unused by now
jcharaoui
force-pushed
the
drop-gettext
branch
from
00b0f0e to
79ded84
Compare
Contributor
Author
|
FWIW I added this patch in the Debian puppetserver package: https://sources.debian.org/src/puppetserver/8.7.0-6/debian/patches/drop-gettext.patch |
ekohl
reviewed
Dec 17, 2025
Contributor
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
There's a merge conflict. Mind rebasing?
I also did some digging. There used to be a dependency on gettext-setup which pulled in gettext but since OpenVoxProject/openvox@53aa50a this is no longer a thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this gem was likely added to support the (brief) module localization effort, in addition to fast_gettext, but it's probably unused by now
see also puppetlabs/r10k#1407