fix: puppet module install should honor manage_file_permissions=false#362
Open
dotconfig404 wants to merge 1 commit intoOpenVoxProject:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
puppet module installcurrently does not honormanage_internal_file_permissions.In the module install path,
Unpacker.harmonize_ownershipalways calls:FileUtils.chown_R(source.stat.uid, source.stat.gid, target)
When running as non-root:
targetalready has that UID/GID, this is effectively a no-op.Errno::EPERM(noCAP_CHOWN).This causes problems when running openvoxserver with arbitrary UIDs, where code/data directories may be owned by a different UID than the runtime user.
Expected behavior: If
manage_internal_file_permissions = false, skip ownership harmonization.Thanks!
PS: This PR will remove the need for this