Update rdoc requirement from ~> 6.0, < 6.4.0 to ~> 6.14#64
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
Update rdoc requirement from ~> 6.0, < 6.4.0 to ~> 6.14#64dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Updates the requirements on [rdoc](https://github.com/ruby/rdoc) to permit the latest version. - [Release notes](https://github.com/ruby/rdoc/releases) - [Changelog](https://github.com/ruby/rdoc/blob/master/History.rdoc) - [Commits](ruby/rdoc@v6.0.0...v6.14.0) --- updated-dependencies: - dependency-name: rdoc dependency-version: 6.14.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Contributor
|
@dependabot rebase |
nmburgan
pushed a commit
that referenced
this pull request
Sep 5, 2025
The validate_vendored_openssl and validate_vendored_ruby tests were failing when run against openvox7. The openssl test was expecting openssl 3 instead of the v1 shipped with openvox7. And the ruby test was attempting a gem update --system which was pulling the latest rubygem-update which is incompatible with the ruby 2.7 shipped with openvox7. Presumably the suite was never run for the puppet 7 collection, or I'm missing something else -- or these tests were specifically skipped? Either way, it was simple enough to add a version test for these two, allowing them to pass by testing for openssl v1, and tightening up the gem update --system to 3.4.22 which was the last rubygems available for ruby 2.7.
nmburgan
pushed a commit
that referenced
this pull request
Sep 5, 2025
(gh-64) Fix two acceptance tests for openvox7
nmburgan
pushed a commit
that referenced
this pull request
Sep 5, 2025
…penvox7" This reverts commit 749850f, reversing changes made to 9eada28. I'd forgotten about the 7.x branch which has the correct tests for openvox7. Have backported the testing pipeline to 7.x in a separate pr, and am reverting the conditional openvox7 changes to the main suite, which should really only be testing openvox8 atm.
nmburgan
pushed a commit
that referenced
this pull request
Sep 5, 2025
...to emphasis that you should use the 7.x branch to test openvox7 rather than setting collection to openvox7. Could also hard set it in the workflow, but thought some flexibility may be better when we start to transition to openvox9, for example.
Contributor
Author
|
Superseded by #224. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on rdoc to permit the latest version.
Release notes
Sourced from rdoc's releases.
Commits
9684f85Bump version to 6.14.0 (#1371)103a6a1Fix PR commenting workflow9dc9211Fetch PR details first to get the correct commit sha06dff66Test workflow fix: use sha for build checkout insteadecef239Add a new workflow to deploy page preview for PRs from forks (#1365)61a2daeLoadcgi/escapeinstead ofcgi/util(#1366)eb05c44Declare erb as a dependency (#1368)8417536Merge pull request #1361 from p8/features/html-langc68ae93Add support for canonical URL link tag (#1354)c0438acSet language in HTMLYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)