4.5.19

[MakinoharaShoko]

No description provided.

[cloudflare-workers-and-pages]

Deploying webgal-dev with    Cloudflare Pages

Latest commit:	9df6af2
Status:	✅  Deploy successful!
Preview URL:	https://a71da497.webgal-dev.pages.dev

View logs

[gemini-code-assist]

Code Review

This pull request updates the WebGAL engine to version 4.5.19, introducing significant UI refinements, improved iOS/Safari support, and a refactored Service Worker for better asset caching. New features include regex validation for user input, Spine skin support, and additional visual filters. The code review identifies opportunities to improve event handling by using addEventListener instead of onkeydown, optimize animation removal logic to avoid O(n^2) complexity, and prevent potential string replacement bugs in user input dialogs by using a function-based replacement in replaceAll.

[gemini-code-assist]

Assigning to document.onkeydown overwrites any existing keydown handlers. It is generally better practice to use addEventListener to allow multiple listeners to coexist without interference.

Suggested change

	document.onkeydown = (e) => {
	if (e && e.key === 'F11') {
	setTimeout(() => {
	scheduleResize();
	}, 100);
	}
	};
	document.addEventListener('keydown', (e) => {
	if (e && e.key === 'F11') {
	setTimeout(() => {
	scheduleResize();
	}, 100);
	}
	});

[gemini-code-assist]

The current implementation of removeAnimationByTargetKey is inefficient because it repeatedly calls findIndex from the start of the array within a while loop, resulting in $O(n^2)$ complexity. Iterating backwards through the array once is a more efficient and standard way to remove multiple elements while ensuring all necessary cleanup (via removeAnimationByIndex) is performed.

Suggested change

	public removeAnimationByTargetKey(targetKey: string) {
	let index = this.stageAnimations.findIndex((e) => e.targetKey === targetKey);
	while (index !== -1) {
	this.removeAnimationByIndex(index);
	index = this.stageAnimations.findIndex((e) => e.targetKey === targetKey);
	}
	}
	public removeAnimationByTargetKey(targetKey: string) {
	for (let i = this.stageAnimations.length - 1; i >= 0; i--) {
	if (this.stageAnimations[i].targetKey === targetKey) {
	this.removeAnimationByIndex(i);
	}
	}
	}

[gemini-code-assist]

Using a string as the second argument to replaceAll can lead to unexpected behavior if the user input contains special replacement patterns (e.g., $&, $$, $1). For example, if a user enters $&, it might result in the literal $0 being inserted instead of the user's actual input. Using a function as the second argument ensures the input is treated as a literal string.

Suggested change

	title: ruleText.replaceAll(/\$0/g, userInput.value),
	title: ruleText.replaceAll(/\$0/g, () => userInput.value),