Skip to content

Declare overture-schema-system dependency#448

Merged
Seth Fitzsimmons (mojodna) merged 1 commit intodevfrom
fix-system-dependency-declarations
Feb 27, 2026
Merged

Declare overture-schema-system dependency#448
Seth Fitzsimmons (mojodna) merged 1 commit intodevfrom
fix-system-dependency-declarations

Conversation

@mojodna
Copy link
Collaborator

@mojodna Seth Fitzsimmons (mojodna) commented Feb 19, 2026

Summary

  • Add overture-schema-system to [project.dependencies] and [tool.uv.sources] for packages that import from overture.schema.system without declaring the dependency: overture-schema-core, overture-schema-cli, overture-schema-base-theme, overture-schema-buildings-theme, overture-schema-transportation-theme
  • These imports resolve in the uv workspace but break isolated installs

Test plan

  • uv sync --all-packages --all-extras resolves cleanly
  • Full test suite passes

These packages import from overture.schema.system without
declaring it as a dependency. Works in the uv workspace
but breaks isolated installs.

- overture-schema-core
- overture-schema-cli
- overture-schema-base-theme
- overture-schema-buildings-theme
- overture-schema-transportation-theme
@RoelBollens-TomTom
Copy link
Collaborator

Since overture-schema-cli, overture-schema-base-theme, overture-schema-buildings-theme, overture-schema-transportation-theme have overture-schema-core as dependency and you added overture-schema-system to overture-schema-core; Is there still a reason to add the overture-schema-system dependency to overture-schema-cli, overture-schema-base-theme, overture-schema-buildings-theme, overture-schema-transportation-theme?

@mojodna
Copy link
Collaborator Author

Since overture-schema-cli, overture-schema-base-theme, overture-schema-buildings-theme, overture-schema-transportation-theme have overture-schema-core as dependency and you added overture-schema-system to overture-schema-core; Is there still a reason to add the overture-schema-system dependency to overture-schema-cli, overture-schema-base-theme, overture-schema-buildings-theme, overture-schema-transportation-theme?

Yes; they reference modules/classes from system so they should depend on it explicitly.

@mojodna Seth Fitzsimmons (mojodna) merged commit 70de652 into dev Feb 27, 2026
5 of 6 checks passed
@mojodna Seth Fitzsimmons (mojodna) deleted the fix-system-dependency-declarations branch February 27, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants