Delete the Windows batch scripts and switch to Bash - #971
Open
NWilson wants to merge 2 commits into
Open
Conversation
On Windows, we now require either WSL Bash or Git-for-Windows bash if you want to run the tests. The harness is a little brittle; but the old batch scripts were fragile too.
NWilson
commented
Sep 3, 2026
| @@ -261,8 +260,6 @@ txt_files=( | |||
| ) | |||
|
|
|||
| crlf_files=( | |||
Member
Author
There was a problem hiding this comment.
Ah, RunShell.bat was meant to have been added here.
NWilson
commented
Sep 3, 2026
| set "RUNSHELL_SCRIPT=%~1" | ||
| ) | ||
|
|
||
| if exist "%SystemRoot%\System32\wsl.exe" ( |
Member
Author
There was a problem hiding this comment.
Ah. Just because wsl.exe exists doesn't mean it's usable. We should query for whether an installation exists firs.
NWilson
commented
Sep 3, 2026
| # Set up the srcdir-relative paths for testing from the srcdir. | ||
|
|
||
| builddir_from_srcdir="`realpath --relative-to="$srcdir" "$builddir"`" | ||
| pcre2grep_from_srcdir="`realpath --relative-to="$srcdir" "$pcre2grep"`" |
Member
Author
There was a problem hiding this comment.
--relative-to isn't in POSIX. I'll need a replacement for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, this PR now requires either WSL Bash or Git-for-Windows bash if you want to run the tests.
The harness is a little brittle; but the old batch scripts were fragile too.
There a little risk with this: people on Windows might run into issues with failing tests and complain.
I do have some fallback options. However, I would like to try this first.
Fixes #652