Allow comment-driven reviews to run on draft PRs#38
Merged
Conversation
This updates the action trigger detection so PR comments with can run reviews directly, without needing a relay mention comment. It also adds support for the pull request event so teams can run a review immediately when a draft is marked ready. The action now adds an reaction when a slash-command review starts and a reaction when review processing completes. Reaction failures are non-fatal so review execution is never blocked by reaction permissions.
Update issue comment trigger detection to run when the comment starts with (ignoring leading whitespace and case), instead of requiring . This matches the simpler command style used in PR conversations.
Rename the action input from to and propagate the environment variable name through enablement logic. This keeps naming aligned with the plain command behavior. Update the completion reaction on command comments from to so completion feedback is distinct from review approval semantics.
The upstream workflow change was rebased onto the fork, but this fork still exposes a dedicated `trigger-on-ready-for-review` input. Keeping `ready_for_review` mapped to its own trigger type preserves that configuration knob while retaining the rebased history on top of `PSPDFKit-labs/main`.
Bot mentions and the review comment command are explicit, per-PR requests from a human, not automatic noise - exempt them from skip-draft-prs so reviewers don't have to flip a PR to ready and back just to get a review while still in draft.
…riggers Covers the trigger types added in prior commits (ready_for_review, slash_command) and the new draft-skip exemption for comment-driven triggers, following the existing test patterns in this file.
pweiskircher
approved these changes
Jul 16, 2026
amit-nayar
marked this pull request as ready for review
July 16, 2026 13:21
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| esac | ||
| elif [ "$EVENT_NAME" == "issue_comment" ]; then | ||
| # Check if comment uses review command trigger | ||
| if echo "$COMMENT_BODY" | grep -qiE '^[[:space:]]*review([[:space:]]|$)'; then |
There was a problem hiding this comment.
🤖 Code Review Finding: review command regex matches casual comments, not just the command
Severity: LOW
Category: correctness
Impact: Unintended full reviews are triggered by ordinary PR conversation that happens to start with the word 'review', causing surprising extra runs and API cost. (Recursion from the bot's own comments is largely prevented by GitHub not re-triggering workflows for events created with the default GITHUB_TOKEN.)
Recommendation: Tighten the pattern to the documented command surface, e.g. only match review optionally followed by please and nothing else (^[[:space:]]*review([[:space:]]+please)?[[:space:]]*$), or require it to be the sole content of the line.
Author
There was a problem hiding this comment.
Agree. tightening to review or review please
The prior pattern matched any comment starting with "review", so ordinary conversation like "review the design doc" would trigger a full run. Require the comment to be exactly "review" or "review please" instead. Addresses #38 (comment)
The inline "Detect trigger type" step (including the review-command and mention regexes) had no test coverage, unlike determine-claudecode-enablement.sh. Pull it into its own script, following the same pattern, and add a test suite covering every trigger type plus the regex edge cases from the review-command fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers currently have to flip a PR out of draft to get a review, then back into draft to keep working -
skip-draft-prsapplies unconditionally to every trigger, including an explicit@botmention or thereviewcomment command.This builds on Daniel Martin's unmerged fork commits (
danielmartin/nutrient-code-review) which add the plainreviewcomment command and splitready_for_reviewinto its own trigger, then adds the missing piece: the draft-PR skip now exemptsmentionandslash_commandtriggers, since those are an explicit per-PR request from a human rather than automatic noise. Automatic triggers (open,commit,ready_for_review) are unaffected and still fully respectskip-draft-prs.One commit from Daniel's fork ("Backport parser and ready-state fixes") was dropped - it re-applied an older, less strict version of review-payload parsing that's already superseded by what's on
main(PR #33), so it only produced merge conflicts with no behavioral gain.Consumer: PSPDFKit/PSPDFKit#55849 pins to this branch and is blocked on this merging.