-
Notifications
You must be signed in to change notification settings - Fork 63
fix: byok compatibility #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sure, I'll get it done tmr 25/01 |
|
@4ndrelim Updated my fix based on your suggested changes! The deeper root cause of this bug is that in Edit: This is the same issue as #99. Either this PR or #100 (which debugs #99) can be used to solve the problem. On hindsight, #100 is probably a more native fix. |
…se eg gpt-5-mini could match to gpt-5
Problem Description
Prod breaks when user provides their own API key.
Cause of Problem
This is because endpoint, API key and model name are hardcoded to be OpenRouter compatible in some methods.
Solution
This PR fixes this breakage by making the definition of endpoint, API key and model name conditional on whether user specifies their own API key.
Notes to Reviewers
Pls help to test this PR's compatibility with OpenRouter API. I only tested it with OpenAI API as I only have OpenAI API key.