fix flaky HeartbeatEndpointSettingsSyncHostedService tests by polling instead of fixed delay - #5756
Draft
soujay wants to merge 2 commits into
Draft
fix flaky HeartbeatEndpointSettingsSyncHostedService tests by polling instead of fixed delay#5756soujay wants to merge 2 commits into
soujay wants to merge 2 commits into
Conversation
… instead of fixed delay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background service work runs asynchronously on the thread pool. Waiting a fixed duration of 2 seconds before asserting is flaky on slower/loaded CI machines because the work may not have completed yet. Instead, this PR polls for the expected condition until it is met or a generous timeout elapses.