Fix flaky ETag validation in event log acceptance tests - #5766
Merged
Conversation
rbev
approved these changes
Aug 14, 2026
| // The endpoint keeps writing startup events, so a 200 here means either the | ||
| // validator went stale between the two requests, or the server ignored | ||
| // If-None-Match. Only the second is a failure, and the ETag tells them apart. | ||
| if (current.StatusCode == HttpStatusCode.OK && ReadEtag(current) != currentEtag) |
Contributor
There was a problem hiding this comment.
Does the 200 with a new e-tag make the test inconclusive?
Shouldn't the Poll() be retrying with the new e-tag until the server goes quiet enough to get a conclusive pass or fail?
The test could fail if new events were written to the log between the initial request and the conditional poll, resulting in a 200 OK instead of a 304 Not Modified. The validation now accounts for this by checking if the ETag has changed when a 200 OK is received.
The test could fail if new events were written to the log between the initial request and the conditional poll. The validation now polls until the log stabilizes or a 304 Not Modified is received to avoid false positives caused by background activity.
johnsimons
force-pushed
the
john/eventlog_etag_test_flake
branch
from
August 14, 2026 04:41
e2740bc to
ee2a455
Compare
johnsimons
enabled auto-merge
August 14, 2026 04:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test could fail if new events were written to the log between the initial request and the conditional poll, resulting in a 200 OK instead of a 304 Not Modified. The validation now accounts for this by checking if the ETag has changed when a 200 OK is received.