Ensure UTC DateTime handling for SQL Server and re-enable retry tests - #5767
Open
johnsimons wants to merge 1 commit into
Open
Ensure UTC DateTime handling for SQL Server and re-enable retry tests#5767johnsimons wants to merge 1 commit into
johnsimons wants to merge 1 commit into
Conversation
SQL Server `datetime2` columns do not store timezone offsets, leading to `DateTimeKind.Unspecified` when retrieved. This adds EF Core value converters to enforce UTC kind on all persisted timestamps and updates acceptance tests to compare UTC instants. These changes allow several previously deferred retry and ingestion acceptance tests to be re-enabled for both SQL Server and PostgreSQL persistence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Server
datetime2columns do not store timezone offsets, leading toDateTimeKind.Unspecifiedwhen retrieved. This adds EF Core value converters to enforce UTC kind on all persisted timestamps and updates acceptance tests to compare UTC instants.These changes allow several previously deferred retry and ingestion acceptance tests to be re-enabled for both SQL Server and PostgreSQL persistence.