Skip to content

Make main socket group guess more fit for poe2 #2536

Description

@vaisest

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

function ImportTabClass:GuessMainSocketGroup()
local largestGroupSize = 0
local largestGroupIndex = 1
for i, socketGroup in ipairs(self.build.skillsTab.socketGroupList) do
if #socketGroup.gemList > largestGroupSize then
largestGroupSize = #socketGroup.gemList
largestGroupIndex = i
end
end
return largestGroupIndex
end

The current socket group guess function is obviously mainly meant for PoE1 since it uses the group size, but for PoE2 this isn't really correct since every group can be a 6 link. It would probably be a good idea to choose the main socket group by e.g. DPS, while also going through different skill sets. Especially some builds like the doedre's frog build have a useless curse as the first stat set which seems to confuse people.

Describe the solution you'd like

123

Describe alternatives you've considered

No response

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature, calculation, or mod

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions