Add proper Pearl of Tsoatha support - #10236
Conversation
| t_insert(node.grantedSkills, { | ||
| skillId = skill.skillId, | ||
| level = skill.level, | ||
| noSupports = true, |
There was a problem hiding this comment.
Technically it seems that this should hide the "You cannot socket gems..." label on the skills tab, but it seems like this feature doesn't work anyway on beta so I'm not sure how much of a problem this is
Fixes the tooltip on the skills tab
LocalIdentity
left a comment
There was a problem hiding this comment.
I fixed 2 tooltip issues. Looks good though
|
Codex found a Trader issue in the Pearl workflow. The Pearl ring selector only changes Keeping the selected slot name available through evaluation, filtering/tooltips, and import auto-equip resolves the reproduced failures. The interactive UI and an authenticated live trade request were not tested. |
Description of the problem being solved:
This adds proper pearl of tsoatha support. This includes
appliesToGrantedSkillsto the on the ExtraSupport mod, and using that to allow it as an exception.It seems that existing ExtraSupport code didn't have protections for duplicate support gems. I had to work around this, and there's a small caveat that they don't show up as (superseded) in the skills tab.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Note that I removed the elem dam mod here: