-
-
Notifications
You must be signed in to change notification settings - Fork 125
Change target Owner on warhead impact #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fryone
wants to merge
24
commits into
Phobos-developers:develop
Choose a base branch
from
Fryone:fryone/owner_changer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+122
−2
Open
Changes from 19 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
55664e1
initial commit
Fryone 6b6f924
Immunities (wip)
Fryone f00d0e6
Docs and fixes
Fryone 3de494f
Merge branch 'develop' into fryone/owner_changer
Fryone 0078e96
Merge branch 'develop' into fryone/owner_changer
Fryone 9215933
Merge branch 'develop' into fryone/owner_changer
Fryone ddc364c
Merge branch 'develop' into fryone/owner_changer
Fryone aef9ebb
Merge branch 'develop' into fryone/owner_changer
Fryone 053a3d0
Merge branch 'develop' into fryone/owner_changer
Fryone a01fd7d
Merge remote-tracking branch 'upstream/develop' into fryone/owner_cha…
Fryone 723551e
Update YRpp
Fryone 1770c6b
Update Detonate.cpp
Fryone 30c3ee4
fix permamc anim not following target
Fryone 0b51abf
updated logic
Fryone 84a4a6c
Merge remote-tracking branch 'upstream/develop' into fryone/owner_cha…
Fryone 75b58dc
Merge branch 'develop' into fryone/owner_changer
Coronia 23e7605
fix mind control anim
Coronia 4eeeff7
remove ChangeOwner.AffectElites
Coronia f05ebbf
Merge remote-tracking branch 'origin/develop' into fryone/owner_changer
Coronia e2d0c38
remove ChangeOwnerImmunities
Coronia 66ba905
Merge branch 'fryone/owner_changer' of https://github.com/Fryone/Phob…
Fryone 4541bac
Added timed control
Fryone e4593a7
update ChangeOwner.Duration
Coronia 63125f9
Merge remote-tracking branch 'upstream/develop' into fryone/owner_cha…
Coronia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of the
ApplyOwnerChangemethod is crucial for implementing the new feature. It's important to ensure that this method is called at the appropriate places within the warhead detonation logic to apply the ownership change effects correctly. Additionally, consider adding error handling within this method to gracefully handle any potential issues that may arise during its execution, such as null references or invalid parameters.Consider adding error handling within the
ApplyOwnerChangemethod to ensure robustness.