Skip to content

Quick Fix: Encounter methods out of order - #1633

Merged
Naramsim merged 1 commit into
PokeAPI:masterfrom
jemarq04:fix/encounter-method-orders
Aug 3, 2026
Merged

Quick Fix: Encounter methods out of order#1633
Naramsim merged 1 commit into
PokeAPI:masterfrom
jemarq04:fix/encounter-method-orders

Conversation

@jemarq04

@jemarq04 jemarq04 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Change description

This is a small PR to address the order field for encounter methods being different from their IDs. This was simply a result of me not addressing that appropriately in my Resources/scripts/data/shift_ids.py helper script, so I've fixed the fields and updated the helper script.

AI coding assistance disclosure

No AI was used.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

…o properly update the order field when shifting encounter methods
@Naramsim
Naramsim merged commit f6918ad into PokeAPI:master Aug 3, 2026
20 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants